gopidesupavan commented on code in PR #61880:
URL: https://github.com/apache/airflow/pull/61880#discussion_r2806076023


##########
airflow/config_templates/config.yml:
##########
@@ -927,6 +927,20 @@ logging:
       default: "dag_id={{ ti.dag_id }}/run_id={{ ti.run_id }}/task_id={{ 
ti.task_id }}/\
                {%% if ti.map_index >= 0 %%}map_index={{ ti.map_index }}/{%% 
endif %%}\
                attempt={{ try_number }}.log"
+    use_historical_filename_templates:
+      description: |
+        When this parameter is set to ``True``, Airflow will use the old 
filename templates for historical
+        tasks. Similarly in this case elasticsearch_id is not properly set for 
historical tasks if you
+        change it. Both require access to the database to render the template 
filenames
+        by webserver, and it might lead to Dag Authors being able to execute 
code on the webserver, that's why
+        it's disabled by default - but it might lead to old logs not being 
displayed in the webserver UI.
+        You can enable it you change the value of ``log_filename_template`` in 
the past and want to be able
+        to see the logs for historical tasks, however you should only do that 
if you trust your Dag authors
+        to not abuse the capability of executing arbitrary code on the 
webserver through template rendering.
+      version_added: 2.1.1

Review Comment:
   ```suggestion
         version_added: 2.11.0
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to