[
https://issues.apache.org/jira/browse/AIRFLOW-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993034#comment-16993034
]
ASF GitHub Bot commented on AIRFLOW-6171:
-----------------------------------------
digger commented on pull request #6784: [AIRFLOW-6171] Apply .airflowignore to
correct subdirectories
URL: https://github.com/apache/airflow/pull/6784
Fix the defect that applied .airflowignore rules from one subdirectory
to all other subdirectories scanned later.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> airflow ignore file with .* located in a subdirectory ignores dags in other
> dirs
> --------------------------------------------------------------------------------
>
> Key: AIRFLOW-6171
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6171
> Project: Apache Airflow
> Issue Type: Bug
> Components: core, DAG
> Affects Versions: 1.10.5, 1.10.6
> Environment: Ubuntu 18.04
> Reporter: Andrey Kateshov
> Priority: Major
>
> I have an airflow dags directory looking like this: x/... y/... z/.... I.e.
> all dags are placed in subdirectories.
> If I place an .airflowignore with a single line of .* in directory z/ the
> dags in other directories (e.g x/ and y/) are also ignored. Which is already
> a big issue. What makes it even stranger that only some of them are ignored,
> potentially masking the effects of this behaviour.
> What makes it even worse you won't see that these dags are now disabled in
> airflow UI unless you completely restart it(possibly together with the
> scheduler, we restarted both, didn't try to see if only the UI is enough).
> This issue was not present in 1.10.3, but appears in 1.10.5. I didn't test
> 1.10.4.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
