anishgirianish opened a new pull request, #61937: URL: https://github.com/apache/airflow/pull/61937
<!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> ## Summary - Implements `ProductMapper` for AIP-76 (Asset Partitions), which combines multiple partition mappers into a Cartesian product using pipe-delimited composite keys (e.g.`"2024-01-01|warehouse-a"`) - Adds core implementation with `to_downstream()`, `serialize()`/`deserialize()`, and SDK stub following the established `IdentityMapper` pattern - Fixes a pre-existing bug in `encode_partition_mapper` that was missing the `is_core_partition_mapper_import_path` check (the timetable equivalent `_get_serialized_timetable_import_path` already had this), which prevented re-serialization of deserialized core mapper instances ## Design decisions - **Delimiter**: Uses `|` (pipe) for composite keys — AIP-76 does not specify a delimiter; this follows Dagster's `MultiPartitionsDefinition` convention - **Validation**: Requires at least 2 child mappers (a product of 1 is meaningless) - **Constraints not enforced here**: "At most one time-based partition" and "no runtime partitioning with ProductMapper" are higher-level concerns per AIP-76, not enforced in the mapper itself Closes: #44145 (ProductMapper portion) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
