potiuk commented on code in PR #58825:
URL: https://github.com/apache/airflow/pull/58825#discussion_r2809242478
##########
airflow-core/src/airflow/settings.py:
##########
@@ -636,6 +636,7 @@ def _configure_secrets_masker():
core_masker.sensitive_variables_fields = list(sensitive_fields)
core_masker.secret_mask_adapter = secret_mask_adapter
+ # TODO: this should be moved out when settings are moved to `shared`
Review Comment:
We are importing "sdk" secrets masker here deliberately - and that should
not happen eventually, because `airflow-core` should not have task-sdk
installed at all. This import will not work after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
