imrichardwu commented on code in PR #61878: URL: https://github.com/apache/airflow/pull/61878#discussion_r2810275378
########## airflow-core/tests/unit/serialization/test_helpers.py: ########## @@ -0,0 +1,136 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from airflow.serialization.helpers import _truncate_rendered_value + + +def test_serialize_template_field_with_very_small_max_length(monkeypatch): + """Test that truncation message is prioritized even for very small max_length.""" + monkeypatch.setenv("AIRFLOW__CORE__MAX_TEMPLATED_FIELD_LENGTH", "1") + + from airflow.serialization.helpers import serialize_template_field + + result = serialize_template_field("This is a long string", "test") + + # The truncation message should be shown even if it exceeds max_length + # This ensures users always see why content is truncated + assert result + assert "Truncated. You can change this behaviour" in result Review Comment: No, the assertion is used to verify that the truncated message is present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
