shahar1 commented on PR #61833: URL: https://github.com/apache/airflow/pull/61833#issuecomment-3907647289
> > It should be clarified and documented how it behaves when a Dag type, or the entire parameter, is removed (e.g., does it respect the catchup parameter?). > > I think the logic is pretty simple. This parameter prevents creation of runs. There are no exceptions thus if you prevent schedule runs all the settings that specify which scheduled runs should be created are ignored. I'll try to clarify - Let's say that using this parameter you allow only asset runs (`allowed_run_types = ['assets']`). At some future point you decide that you want to re-add scheduled runs (`allowed_run_types =['assets', 'scheduled']`). 1. Do we respect the `catchup` parameter in this case to complete past runs? (see followup) 2. If we do, are **all** past scheduled runs are queued, or only those between setting the initial setting of `allowed_run_types` and updating it? You might had set `catchup=False` before adding `allowed_run_types`, and if you now change both `catchup=True` and allow scheduled runs, there will be a lot of potentially unnecessary runs for the users. We could keep it simple for now and make the required assumptions, but it should be documented IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
