TobKed commented on a change in pull request #6780: [AIRFLOW-4899] Fix BQ Hook
- get_datasets_list uses pagination (#6780)
URL: https://github.com/apache/airflow/pull/6780#discussion_r356437649
##########
File path: airflow/gcp/hooks/bigquery.py
##########
@@ -1798,17 +1798,22 @@ def get_dataset(self, dataset_id: str, project_id:
Optional[str] = None) -> Dict
return dataset_resource
- def get_datasets_list(self, project_id: Optional[str] = None) -> List:
+ @CloudBaseHook.catch_http_exception
+ def get_datasets_list(self, project_id=None, max_results=None,
all_datasets=False):
Review comment:
Could you add type annotations, please? I think it is good idea to keep them
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
