Miretpl commented on code in PR #62052:
URL: https://github.com/apache/airflow/pull/62052#discussion_r2814298770
##########
helm-tests/tests/helm_tests/apiserver/test_apiserver.py:
##########
@@ -76,6 +76,30 @@ def
test_should_add_volume_and_volume_mount_when_exist_api_server_config(self):
"readOnly": True,
} in jmespath.search("spec.template.spec.containers[0].volumeMounts",
docs[0])
+ def test_should_remove_replicas_field(self):
+ docs = render_chart(
+ values={
+ "airflowVersion": "3.0.0",
Review Comment:
Could we also add tests for the default version?
##########
chart/templates/api-server/api-server-deployment.yaml:
##########
@@ -47,7 +47,9 @@ metadata:
annotations: {{- toYaml .Values.apiServer.annotations | nindent 4 }}
{{- end }}
spec:
+ {{- if not .Values.apiServer.hpa.enabled }}
Review Comment:
Should be both, but currently, there is only support for HPA in API Server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
