justinpakzad commented on code in PR #61965:
URL: https://github.com/apache/airflow/pull/61965#discussion_r2814224217
##########
providers/postgres/tests/unit/postgres/hooks/test_postgres.py:
##########
@@ -304,18 +304,22 @@ def test_get_conn_extra(self, mock_connect):
@pytest.mark.parametrize("aws_conn_id", [NOTSET, None, "mock_aws_conn"])
@pytest.mark.parametrize("port", [5432, 5439, None])
@pytest.mark.parametrize(
- ("host", "conn_cluster_identifier", "expected_cluster_identifier"),
+ ("host", "conn_cluster_identifier", "expected_cluster_identifier",
"raises_exception"),
[
(
"cluster-identifier.ccdfre4hpd39h.us-east-1.redshift.amazonaws.com",
NOTSET,
"cluster-identifier",
+ False,
),
(
"cluster-identifier.ccdfre4hpd39h.us-east-1.redshift.amazonaws.com",
"different-identifier",
"different-identifier",
+ False,
),
+ (None, NOTSET, None, True),
+ (None, "cluster-identifier", "cluster-identifier", False),
Review Comment:
Given the changes I'm going to make (e.g., only fetching the cluster id from
the host when cluster_identifier is not provided or None), not sure we need the
additional empty string test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
