jscheffl commented on code in PR #61812:
URL: https://github.com/apache/airflow/pull/61812#discussion_r2818972722
##########
providers/edge3/src/airflow/providers/edge3/worker_api/routes/jobs.py:
##########
@@ -87,8 +87,6 @@ def fetch(
# Edge worker does not backport emitted Airflow metrics, so export some
metrics
tags = {"dag_id": job.dag_id, "task_id": job.task_id, "queue": job.queue}
try:
- from airflow.sdk._shared.observability.metrics.dual_stats_manager
import DualStatsManager
-
DualStatsManager.incr("edge_worker.ti.start", tags=tags)
Review Comment:
Okay, still a bit unclear to me... to be able to find and clean-up
deprecations in future, can you please use `if AIRFLOW_V_3_2_PLUS:` like in
other situations rather than try/except? Then we have a direct marker what to
remove if we drop lower-bound compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
