sjyangkevin commented on code in PR #62059: URL: https://github.com/apache/airflow/pull/62059#discussion_r2819429425
########## .github/skills/airflow-translations/SKILL.md: ########## @@ -0,0 +1,155 @@ +--- +name: airflow-translations +description: > + Translate, review, and maintain Apache Airflow i18n locale strings in JSON + translation files. Use when working with internationalization, localization, + or translation tasks in airflow-core/src/airflow/ui/public/i18n/locales/. + Covers Airflow terminology conventions and translation guidelines. +license: Apache-2.0 +--- + +# Airflow Translations + +## Locale-Specific Guidelines + +Before translating, you **must** read the locale-specific guideline file for +the target language. Locale files are located at `locales/<locale-name>.md` +relative to this skill directory. + +Match the translation task to the correct locale file using the table below: + +| Locale Code | Language | Guideline File | +| ----------- | ----------------------- | ------------------------------- | +| `ar` | Arabic | [locales/ar.md](locales/ar.md) | +| `ca` | Catalan | [locales/ca.md](locales/ca.md) | +| `de` | German | [locales/de.md](locales/de.md) | Review Comment: The structure (naming schema) defined here follows the proposal below (which is shared by @jason810496 in the dev list), which is not the locales file defined under the `airflow-core/src/airflow/ui/public/i18n/locales`, but a file can be referenced from the `SKILL.md` for the agent to look at a language-specific instruction. ``` .github/skills/airflow-translations ├── locales │ ├── ar.md │ # ... all current locales, each with locale-specific skills │ └── zh-TW.md └── SKILL.md # Global-level Airflow terminology guidelines ``` Looking into the `airflow-core/src/airflow/ui/public/i18n/locales`, I found some translations come with a `README.md`, but not all of those have one. I think the one in German is functionally the same as what we would like to put under `.github/skills/airflow-translations/locales`. The file provides detailed and clear information on the translation guideline if I understand correctly; and it is something can be moved directly into the skills folder. The trade-off is discussed in the comment below: https://github.com/apache/airflow/pull/62059#discussion_r2819178634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
