SameerMesiah97 commented on code in PR #62082:
URL: https://github.com/apache/airflow/pull/62082#discussion_r2819999916
##########
providers/google/src/airflow/providers/google/cloud/triggers/dataproc.py:
##########
@@ -187,9 +187,13 @@ async def safe_to_cancel(self) -> bool:
return task_state != TaskInstanceState.DEFERRED
async def run(self):
+ hook = self.get_async_hook()
+ # Trigger client cache with sync call get_credentials(), evaluated
once.
+ await hook.get_job_client(region=self.region)
Review Comment:
Since the client is now initialized once and reused for the trigger
lifetime, do we rely on google-auth’s automatic credential refresh? Just
checking that long-running triggers won’t fail due to token expiry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
