shahar1 commented on code in PR #61927: URL: https://github.com/apache/airflow/pull/61927#discussion_r2820985065
########## providers/google/docs/changelog.rst: ########## @@ -85,6 +85,10 @@ Doc-only 19.5.0 ...... +.. warning:: + We have identified regressions in Cloud Run and Gemini AI operators within this version that may cause unexpected behavior (connectivity errors and incorrect task success states). + We are aware of these issues, and official fixes will be available in the next release. Review Comment: My 2 cents: 1. In any case, I'd wait with merging this PR until the fix is actually released in the next wave. 2. Maybe we could change the sentence to be a specific oneliner i.e., `in this version there's a regression in deferrable mode of CloudRunJobExecuteJobOperator which makes it unusable - fixed in version 20.0.0`. That way, if this version is installed as a default by some Airflow service provider (e.g., Cloud Composer) and people want to know why they suddently encounter a regression - they could go to the specific version's changelog and decide whether they want to upgrade or wait with it. 3. I don't think that we should do that for any kind of bug we encounter, but in the case of regressions I think that it's justified. ########## providers/google/docs/changelog.rst: ########## @@ -85,6 +85,10 @@ Doc-only 19.5.0 ...... +.. warning:: + We have identified regressions in Cloud Run and Gemini AI operators within this version that may cause unexpected behavior (connectivity errors and incorrect task success states). + We are aware of these issues, and official fixes will be available in the next release. Review Comment: My 2 cents: 1. In any case, I'd wait with merging this PR until the fix is actually released in the next wave. 2. Maybe we could change the sentence to be a specific oneliner i.e., `in this version there's a regression in deferrable mode of CloudRunJobExecuteJobOperator which makes it unusable - fixed in version 20.0.0`. That way, if this version is installed as a default by some Airflow service provider (e.g., Cloud Composer) and people want to know why they suddently encounter a regression - they could go to the specific version's changelog and decide whether they want to upgrade or wait with it. 3. I don't think that we should do that for any kind of bug we encounter, but in the case of regressions I think that it's rather justified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
