eladkal commented on code in PR #62121:
URL: https://github.com/apache/airflow/pull/62121#discussion_r2822034675
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -279,35 +279,29 @@ def _default_conn_name_from(mod_path, hook_name):
)
remote_task_handler_kwargs = {}
elif ELASTICSEARCH_HOST:
- ELASTICSEARCH_END_OF_LOG_MARK: str =
conf.get_mandatory_value("elasticsearch", "END_OF_LOG_MARK")
- ELASTICSEARCH_FRONTEND: str =
conf.get_mandatory_value("elasticsearch", "frontend")
+ from airflow.providers.elasticsearch.log.es_task_handler import
ElasticsearchRemoteLogIO
Review Comment:
I think we need also min elastic version in
https://github.com/apache/airflow/blob/7c01e0b3f7a227494c4a754fbd65855620382f2a/scripts/ci/prek/update_airflow_pyproject_toml.py#L75
Because we know this won't work with older version of elastic provider
Need to verify with @potiuk this is the right way to proceed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
