Eason09053360 commented on code in PR #61934:
URL: https://github.com/apache/airflow/pull/61934#discussion_r2822330955
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/JobsPage.tsx:
##########
@@ -94,26 +237,14 @@ export const JobsPage = () => {
))}
</Table.Body>
</Table.Root>
- </Box>
- );
- if (data) {
- return (
- <Text as="div" pl={4} pt={1}>
- Currently no jobs running. Start a Dag and then all active jobs should
show up here. Note that after
- some (configurable) time, jobs are purged from the list.
- </Text>
- );
- }
- if (error) {
- return (
- <Text as="div" pl={4} pt={1}>
- <ErrorAlert error={error} />
- </Text>
- );
- }
- return (
- <Text as="div" pl={4} pt={1}>
- Loading...
- </Text>
+ ) : data ? (
+ <Text>
+ Currently no jobs running. Start a Dag and then all active jobs
should show up here. Note that
+ after some (configurable) time, jobs are purged from the list.
Review Comment:
> Beautification-nit: Can you change the text depending on filter is
applied? I think this text is "good" only if the resulting list is empty. But
it might be empty because the used filer just does not have result. Can you
have a different text is a filter is set?
Thanks for the suggestion! I've updated the logic to display different
messages depending on whether filters are active.
If filters are applied, it shows:
'No jobs match the current filters. Try adjusting or clearing filters.'
If no filters are applied, it shows:
'Currently no jobs running. Start a Dag and then all active jobs should show
up here‘
Let me know if this wording works for you ：）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
