kaxil commented on code in PR #62128:
URL: https://github.com/apache/airflow/pull/62128#discussion_r2822760868
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -393,11 +393,16 @@ def _run_parsing_loop(self):
self._refresh_dag_bundles(known_files=known_files)
if not self._file_queue:
+ if self._parsing_start_time:
Review Comment:
Could you add a simple test:
1) First cycle with empty queue does not emit parse-time metric and does not
crash,
2) Subsequent empty-queue transition emits `dag_processing.total_parse_time`
from the previous cycle window,
3) `_parsing_start_time` reset semantics are correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
