bugraoz93 commented on code in PR #61822: URL: https://github.com/apache/airflow/pull/61822#discussion_r2824754056
########## airflow-ctl-tests/tests/airflowctl_tests/test_airflowctl_commands.py: ########## @@ -125,7 +125,7 @@ def date_param(): ] [email protected](reruns=3, reruns_delay=1) +# @pytest.mark.flaky(reruns=3, reruns_delay=1) Review Comment: ```suggestion @pytest.mark.flaky(reruns=3, reruns_delay=1) ``` ########## airflow-ctl-tests/tests/airflowctl_tests/test_config_sensitive_masking.py: ########## @@ -17,17 +17,20 @@ from __future__ import annotations import pytest +from packaging.version import Version + +from airflowctl_tests.constants import TEST_AIRFLOW_VERSION # Test commands for config sensitive masking verification SENSITIVE_CONFIG_COMMANDS = [ - # Test that config list shows masked sensitive values - "config list", + # List method not return anything sensitive # Test that getting specific sensitive config values are masked "config get --section core --option fernet_key", "config get --section database --option sql_alchemy_conn", ] [email protected](Version("3.1.7") > TEST_AIRFLOW_VERSION, reason="Implemented after Airflow v3.1.7") Review Comment: ```suggestion @pytest.mark.skipif(Version("3.1.7") >= TEST_AIRFLOW_VERSION, reason="Implemented after Airflow v3.1.7") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
