cruseakshay opened a new pull request, #62153:
URL: https://github.com/apache/airflow/pull/62153
## Problem
When using FAB auth manager, a database connection drop (e.g. PostgreSQL's
`idle_in_transaction_session_timeout`) causes the API server to return HTTP
500
on **every subsequent request** until it is restarted.
The cascade happens in the JWT auth path hit on every authenticated request:
`JWTRefreshMiddleware` → `resolve_user_from_token` → `deserialize_user`
`deserialize_user` uses FAB's scoped session (`self.appbuilder.session`).
When a
connection dies, SQLAlchemy raises `OperationalError` on the first request
and
leaves the session in an invalid state. All following requests reuse the same
poisoned thread-local session and raise `PendingRollbackError`.
This is distinct from the WSGI Flask-view path fixed in #61480 and the
`load_user` path fixed in #61943 — those do not cover the JWT token
deserialization path.
## Solution
Catch `SQLAlchemyError` in `deserialize_user`, call `session.remove()` to
discard the poisoned scoped session, and re-raise the original exception.
The next request gets a fresh connection from the pool and succeeds.
`session.remove()` is wrapped in `contextlib.suppress(Exception)` so a
failure
during cleanup can never mask the original database error.
- **First request after a drop**: unavoidable 500 (the dead connection must
be
discovered) — behaviour is unchanged.
- **All subsequent requests**: recover automatically — no restart needed.
## Testing
- `test_db_error_calls_session_remove` — parametrized over `OperationalError`
and `PendingRollbackError`: verifies `session.remove()` is called on each.
- `test_db_error_propagates_when_session_remove_raises` — verifies the
original
`SQLAlchemyError` is always what propagates, even when `session.remove()`
itself
throws.
Fixes #61761
Related to #61480, #61943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
