choo121600 commented on code in PR #53216:
URL: https://github.com/apache/airflow/pull/53216#discussion_r2825940327
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskInstancesColumn.tsx:
##########
@@ -90,6 +115,23 @@ export const TaskInstancesColumn = ({ nodes, onCellClick,
run, virtualItems }: P
);
}
+ let hasVersionChangeFlag = false;
+
+ if (
+ hasMixedVersions &&
+ (showVersionIndicatorMode === VersionIndicatorDisplayOptions.DAG ||
+ showVersionIndicatorMode === VersionIndicatorDisplayOptions.ALL) &&
+ idx > 0
+ ) {
+ const prevVirtualItem = itemsToRender[idx - 1];
+ const prevNode = prevVirtualItem ? nodes[prevVirtualItem.index] :
undefined;
+ const prevTaskInstance = prevNode ? taskInstanceMap.get(prevNode.id)
: undefined;
+
+ hasVersionChangeFlag = Boolean(
+ prevTaskInstance && prevTaskInstance.dag_version_number !==
taskInstance.dag_version_number,
+ );
+ }
+
Review Comment:
bundle_version is a DagRun-level column, so all TaskInstances within a
single run share the same value, as I understand it.
Bundle version changes between runs are already handled in Bar.tsx via
isBundleVersionChange.
Since this comparison operates within a single run, my understanding is that
only `dag_version_number` would differ across TaskInstances.
Let me know if I'm missing something!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
