xBis7 commented on code in PR #62154:
URL: https://github.com/apache/airflow/pull/62154#discussion_r2826368644
##########
shared/observability/src/airflow_shared/observability/traces/otel_tracer.py:
##########
Review Comment:
This should also be removed entirely. Generating a span_id and a trace_id
are internal operations of the SDK and we shouldn't mess with them.
##########
shared/observability/src/airflow_shared/observability/traces/otel_tracer.py:
##########
@@ -322,33 +319,19 @@ def gen_links_from_kv_list(kv_list):
return result
-def gen_link_from_traceparent(traceparent: str):
Review Comment:
+1 on this change.
##########
airflow-core/src/airflow/observability/trace.py:
##########
@@ -17,16 +17,44 @@
from __future__ import annotations
Review Comment:
There has been a plan to refactor this, add an `initialize` method and move
it under shared, similarly to `Stats`.
Also related
https://github.com/apache/airflow/pull/62127
cc @potiuk @amoghrajesh
##########
shared/observability/src/airflow_shared/observability/traces/otel_tracer.py:
##########
@@ -322,33 +319,19 @@ def gen_links_from_kv_list(kv_list):
return result
-def gen_link_from_traceparent(traceparent: str):
Review Comment:
And these as well, aren't used and should be removed
https://github.com/astronomer/airflow/blob/e604a20a21447579488cfd8fe48061dd625e0259/shared/observability/src/airflow_shared/observability/traces/utils.py#L42-L62
They are doing what `extract()` and `inject()` are designed to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
