amoghrajesh commented on code in PR #62127:
URL: https://github.com/apache/airflow/pull/62127#discussion_r2828041865
##########
task-sdk/src/airflow/sdk/observability/metrics/statsd_logger.py:
##########
@@ -29,7 +29,7 @@
log = logging.getLogger(__name__)
-def get_statsd_logger(cls) -> SafeStatsdLogger:
+def get_statsd_logger() -> SafeStatsdLogger:
Review Comment:
Here too I guess?
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -271,11 +272,8 @@ def run(self):
# Related: https://github.com/apache/airflow/pull/57459
os.environ["_AIRFLOW_PROCESS_CONTEXT"] = "server"
- Stats.initialize(
- is_statsd_datadog_enabled=conf.getboolean("metrics",
"statsd_datadog_enabled"),
- is_statsd_on=conf.getboolean("metrics", "statsd_on"),
- is_otel_on=conf.getboolean("metrics", "otel_on"),
- )
+ stats_factory = stats_utils.get_stats_factory(Stats)
+ Stats.initialize(factory=stats_factory)
Review Comment:
Yeah thought so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
