stephen-bracken opened a new pull request, #62180:
URL: https://github.com/apache/airflow/pull/62180
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
When parsing a connection from a URI, the password gets leaked in task logs.
This PR sanitises the password if it is present in the URI during
`_parse_from_uri()`
example of the problem:
```
Traceback (most recent call last):
File
"/home/airflow/.local/lib/python3.8/site-packages/airflow/models/connection.py",
line 526, in get_connection_from_secrets
conn = secrets_backend.get_connection(conn_id=conn_id)
File
"/home/airflow/.local/lib/python3.8/site-packages/airflow/secrets/base_secrets.py",
line 116, in get_connection
return self.deserialize_connection(conn_id=conn_id, value=value)
File
"/home/airflow/.local/lib/python3.8/site-packages/airflow/secrets/base_secrets.py",
line 70, in deserialize_connection
return Connection(conn_id=conn_id, uri=value)
File "<string>", line 4, in __init__
File
"/home/airflow/.local/lib/python3.8/site-packages/sqlalchemy/orm/state.py",
line 482, in _initialize_instance
manager.dispatch.init_failure(self, args, kwargs)
File
"/home/airflow/.local/lib/python3.8/site-packages/sqlalchemy/util/langhelpers.py",
line 70, in __exit__
compat.raise_(
File
"/home/airflow/.local/lib/python3.8/site-packages/sqlalchemy/util/compat.py",
line 211, in raise_
raise exception
File
"/home/airflow/.local/lib/python3.8/site-packages/sqlalchemy/orm/state.py",
line 479, in _initialize_instance
return manager.original_init(*mixed[1:], **kwargs)
File
"/home/airflow/.local/lib/python3.8/site-packages/airflow/models/connection.py",
line 169, in __init__
self._parse_from_uri(uri)
File
"/home/airflow/.local/lib/python3.8/site-packages/airflow/models/connection.py",
line 248, in _parse_from_uri
raise AirflowException(f"Invalid connection string: {uri}.")
airflow.exceptions.AirflowException: Invalid connection string:
http://http/://myuser:[email protected]:8080/http.
```
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
