pierrejeambrun commented on code in PR #62169:
URL: https://github.com/apache/airflow/pull/62169#discussion_r2829061662
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/ui/config.py:
##########
@@ -36,3 +37,6 @@ class ConfigResponse(BaseModel):
external_log_name: str | None = None
theme: Theme | None
multi_team: bool
+ # added custom logo support
+ custom_logo: Optional[str] = None
+
Review Comment:
We already have a THEME config object to customize the UI.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/config.py:
##########
@@ -45,6 +45,7 @@
@config_router.get(
"/config",
+ response_model=ConfigResponse,
Review Comment:
why? unrelated?
##########
airflow-core/src/airflow/ui/src/layouts/Nav/Nav.tsx:
##########
@@ -27,8 +27,9 @@ import {
usePluginServiceGetPlugins,
} from "openapi/queries";
import type { ExternalViewResponse } from "openapi/requests/types.gen";
-import { AirflowPin } from "src/assets/AirflowPin";
import { DagIcon } from "src/assets/DagIcon";
+// import { AirflowPin } from "src/assets/AirflowPin";
Review Comment:
?
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/config.py:
##########
@@ -62,6 +63,8 @@ def get_configs() -> ConfigResponse:
"external_log_name": getattr(task_log_reader.log_handler, "log_name",
None),
"theme": loads(conf.get("api", "theme", fallback="{}")) or None,
"multi_team": conf.getboolean("core", "multi_team"),
+ # for sustom logo
Review Comment:
typo
##########
airflow-core/src/airflow/ui/openapi-gen/queries/queries.ts:
##########
@@ -407,6 +407,7 @@ export const useDagStatsServiceGetDagStats = <TData =
Common.DagStatsServiceGetD
* @returns Config Successful Response
* @throws ApiError
*/
+
Review Comment:
why?
##########
airflow-core/src/airflow/ui/openapi-gen/requests/core/OpenAPI.ts:
##########
@@ -49,7 +49,7 @@ export const OpenAPI: OpenAPIConfig = {
TOKEN: undefined,
USERNAME: undefined,
VERSION: '2',
- WITH_CREDENTIALS: false,
+ WITH_CREDENTIALS: true,
Review Comment:
why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
