[
https://issues.apache.org/jira/browse/AIRFLOW-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993968#comment-16993968
]
ASF GitHub Bot commented on AIRFLOW-1076:
-----------------------------------------
dhuang commented on pull request #6793: [AIRFLOW-1076] Add get method for
template variable accessor
URL: https://github.com/apache/airflow/pull/6793
Support getting variables in templates by string. This is necessary when
fetching variables with characters not allowed in a class attribute
name. We can then also support returning default values when a variable does
not exist.
Original PR went stale, https://github.com/apache/airflow/pull/2223.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-1076
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
- See above.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- Added unit tests for calling `var.value.get()` and `var.json.get()`,
with or without default
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support getting variable by string in templates
> -----------------------------------------------
>
> Key: AIRFLOW-1076
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1076
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Daniel Huang
> Assignee: Daniel Huang
> Priority: Minor
>
> Currently, one can fetch variables in templates with {{ var.value.foo }}. But
> that doesn't work if the variable key has a character you can't use as an
> attribute, like ":" or "-".
> Should provide alternative method of {{ var.value.get('foo:bar') }}. Can then
> also supply a default value if the variable is not found. This also allows
> you to fetch the variable specified in another jinja variable (probably not
> common use case).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
