Srabasti commented on PR #62102: URL: https://github.com/apache/airflow/pull/62102#issuecomment-3931744981
> > Looks like typo "perimiter -> "perimeter" is causing spell check to fail. > > Thanks for the review @Srabasti! 😃 I will fix that. > > Note: Please don't put a Request for Change on a PR unless the change is absolutely critical and there is no way it should be merged. Otherwise it makes it difficult to merge afterwards until the request is cleared (or it's cleared manually). In this case the failing build will be enough to block merging until it is fixed 🙂 Oh I was not aware of this! I have observed others (maintainers + non-maintainers) reviewing my PR and other PRs same way hence thought this is norm. Apologies for the inconvenience. Just wanted to mention that I did not receive a request to approve - hence was not aware were waiting for my approval. Possibly a system glitch. Thanks for bringing this to my attention! As an afterthought, the contributing docs should be updated for contributors to review only via commenting on PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
