amoghrajesh opened a new pull request, #62210:
URL: https://github.com/apache/airflow/pull/62210
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes - cursor IDE
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Part of the effort for client server separation where priority weight
strategies were imported from airflow-core into task sdk. To get rid of those
imports, introduce `WeightRuleProtocol` and `WeightRuleParam` in the task SDK
which can be used for type hints.
This doesn't impact dag authors in any ways, just internal import change,
dag authors can continue using the functionality as usual.
### Testing
Tested with a custom plugin weight to see if it works as expected.
Plugin:
```python
from airflow.plugins_manager import AirflowPlugin
from airflow.task.priority_strategy import PriorityWeightStrategy
class HighPriorityStrategy(PriorityWeightStrategy):
"""Always returns high weight - scheduled first when queue is busy."""
def get_weight(self, ti):
return 100
class LowPriorityStrategy(PriorityWeightStrategy):
"""Always returns low weight - scheduled last when queue is busy."""
def get_weight(self, ti):
return 1
class MyWeightPlugin(AirflowPlugin):
name = "my_weight_plugin"
priority_weight_strategies = [HighPriorityStrategy, LowPriorityStrategy]
```
- Set a slot with 2 pool size
DAG:
```python
from airflow.providers.standard.operators.bash import BashOperator
from airflow.sdk import DAG
from my_weights import HighPriorityStrategy, LowPriorityStrategy
with DAG("test_custom_weight") as dag:
high1 = BashOperator(task_id="high_1", bash_command="sleep 5",
weight_rule=HighPriorityStrategy(), pool="my_pool")
high2 = BashOperator(task_id="high_2", bash_command="sleep 5",
weight_rule=HighPriorityStrategy(), pool="my_pool")
low1 = BashOperator(task_id="low_1", bash_command="sleep 5",
weight_rule=LowPriorityStrategy(), pool="my_pool")
low2 = BashOperator(task_id="low_2", bash_command="sleep 5",
weight_rule=LowPriorityStrategy(), pool="my_pool")
```
<img width="1708" height="517" alt="image"
src="https://github.com/user-attachments/assets/e9bbd06f-8d3e-4c0e-9d52-d949798d3363";
/>
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
