kimyoungi99 commented on PR #62214:
URL: https://github.com/apache/airflow/pull/62214#issuecomment-3936162641

   Fixed the CI failure in `test_upgradedb[auth1-2]`.
   
   The initial singleton implementation cached the auth manager instance 
unconditionally, but `upgradedb()` switches between auth manager classes via 
config (e.g. SimpleAuthManager → FabAuthManager). The cached instance from a 
previous config was being returned instead of creating a new one for the 
updated config.
   
   Added an `isinstance` check so the singleton is invalidated when the 
configured auth manager class changes. The thread-safety guarantee 
(double-checked locking) remains intact.
   
   - `test_upgradedb[auth0-1]` ✅
   - `test_upgradedb[auth1-2]` ✅ (was failing)
   - `test_create_auth_manager_thread_safety` ✅


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to