uplsh580 opened a new pull request, #62277:
URL: https://github.com/apache/airflow/pull/62277
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Related PR
- https://github.com/apache/airflow/issues/62272
## Problem
When running `breeze start-airflow` or asset compilation, users could
encounter:
1. **Version check failure**: "Package name prek version is wrong. It should
be at least 0.3.2 and is 0.2.25" — even when prek 0.3.3 was installed in the
breeze Python environment
2. **Asset compilation failure**: "Required minimum prek version `0.3.2` is
greater than current version `0.2.25`"
This occurred because breeze was checking and invoking prek from `PATH`,
which could point to an older standalone installation (e.g. `uv tool install
prek` at 0.2.25), while breeze's own environment had the correct version
(0.3.3) in its bin directory.
## Solution
- **`get_prek_executable()`**: New helper that returns the path to prek in
the same bin directory as breeze's Python (`sys.executable`'s parent)
- **`assert_prek_installed()`**: Uses `get_prek_executable()` instead of
`"prek"` from PATH, so the version check uses breeze's prek
- **`run_compile_ui_assets()`**: Uses `get_prek_executable()` instead of
`"prek"`, so asset compilation invokes the correct prek version
## Error message improvements
- When prek version is insufficient: suggests `uv tool install -e
./dev/breeze --force` to reinstall breeze with updated dependencies
- When prek is not found: same reinstall suggestion (breeze includes prek as
a dependency)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
cursor
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
