mik-laj commented on a change in pull request #6792: [AIRFLOW-5930] Use
cached-SQL query building for hot-path queries
URL: https://github.com/apache/airflow/pull/6792#discussion_r356988211
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -686,10 +664,10 @@ def _process_dags(self, dagbag, dags, tis_out):
:type dagbag: airflow.models.DagBag
:param dags: the DAGs from the DagBag to process
:type dags: airflow.models.DAG
- :param tis_out: A list to add generated TaskInstance objects
- :type tis_out: list[TaskInstance]
- :rtype: None
+ :return: A list of TaskInstance objects
+ :rtype: list[TaskInstance]
Review comment:
Can you also add rtype for _process_task_instances also? Now it is difficult
to check if this is true. Especially since this method previously use
TaskInstanceKeyType.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
