uplsh580 opened a new pull request, #62281:
URL: https://github.com/apache/airflow/pull/62281

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   # Fix docker-stack "Unsupported package" error in publish-docs
   
   ## Problem
   
   The CI job "Publish documentation and validate versions" fails with:
   
   ```
   Unsupported package: docker-stack
   Publishing docs for 104 package(s)
    - apache-airflow-providers-http: 6.0.0
    ...
   Error: Process completed with exit code 1.
   ```
   
   ## Root cause
   
   `get_package_version_possibly_from_stable_txt()` is called for each package 
before publishing to print versions. It handles `apache-airflow`, `helm-chart`, 
`task-sdk`, `apache-airflow-providers-*`, etc., but has no case for 
`docker-stack`.
   
   `docker-stack` is a non-versioned package 
(`DocsPublisher.is_versioned=False`) and is published to 
`docs-archive/docker-stack` without a version subdirectory. The function raised 
`SystemExit` when it encountered this package.
   
   ## Solution
   
   - Add handling for `docker-stack` in 
`get_package_version_possibly_from_stable_txt()` to return `"non-versioned"` 
instead of raising
   - Add unit test for this case
   
   ## Changes
   
   - `dev/breeze/src/airflow_breeze/commands/release_management_commands.py`: 
Handle `docker-stack` in version lookup
   - `dev/breeze/tests/test_release_management_publish_docs.py`: New test file 
for the fix
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [X] Yes (please specify the tool below)
   Cursor
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to