Ajay9704 commented on code in PR #61596:
URL: https://github.com/apache/airflow/pull/61596#discussion_r2838290465
##########
airflow-core/docs/best-practices.rst:
##########
@@ -465,15 +465,20 @@ Good example:
.. code-block:: python
- from airflow.sdk import Variable
from airflow.timetables.interval import CronDataIntervalTimetable
-
Review Comment:
>All changes made by hooks:
-diff --git a/airflow-core/docs/best-practices.rst
b/airflow-core/docs/best-practices.rst
-index a3240a5..6c9adb5 100644
--- a/airflow-core/docs/best-practices.rst
+++ b/airflow-core/docs/best-practices.rst
@@ -467,6 +467,7 @@ Good example:
from airflow.timetables.interval import CronDataIntervalTimetable
"+"
> class CustomTimetable(CronDataIntervalTimetable):
def __init__(self, *args, something="something", **kwargs):
self._something = something
>Error: Process completed with exit code 1.
If you add back the whitespace here, the static checks might pass.
Based on the logs, the issue is specifically with this line — restoring the
blank line should fix the RST formatting, so adding it back might work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
