albertusk95 commented on a change in pull request #6795: Adjust the MASTER_URL
of spark-submit in SparkSubmitHook
URL: https://github.com/apache/airflow/pull/6795#discussion_r357033176
##########
File path: airflow/contrib/hooks/spark_submit_hook.py
##########
@@ -185,6 +185,8 @@ def _resolve_connection(self):
conn_data['master'] = "{}:{}".format(conn.host, conn.port)
else:
conn_data['master'] = conn.host
+ if conn.uri:
+ conn_data['master'] = conn.uri
Review comment:
hmm but what if the `extra` attribute is needed? I mean, based on
[this](https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/spark_submit_hook.py#L190),
we can retrieve additional `spark-submit` params, such as deploy-mode,
spark-binary, etc.).
If the URI is exactly the same as the MASTER_URL, how to extract this
`extra` values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
