anyeole commented on code in PR #62327:
URL: https://github.com/apache/airflow/pull/62327#discussion_r2839033656
##########
providers/fab/src/airflow/providers/fab/auth_manager/api_fastapi/datamodels/users.py:
##########
@@ -16,6 +16,7 @@
# under the License.
from __future__ import annotations
+import datetime
from pydantic import Field, SecretStr
from airflow.api_fastapi.common.types import UtcDateTime
Review Comment:
Hey, we actually have to keep it! Airflow's common.types only provides the
timezone-aware UtcDateTime
wrapper. Since this PR specifically needs the standard, naive datetime
object to stay compatible with the old Flask-AppBuilder database model, we
have to import it straight from the standard library. But I did clean it up so
we just import datetime directly from datetime now instead of import datetime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
