SakshamSinghal20 commented on PR #62225: URL: https://github.com/apache/airflow/pull/62225#issuecomment-3946577648
Great catch, @SameerMesiah97! You were spot on about the implicit semantics dropping those alerts for legacy DAGs would have been a bad side effect. I've just pushed a new commit that fixes this. Instead of skipping the requests, the logic now safely falls back so that TaskCallbackRequest and EmailCallbackRequest are still triggered even when ti.dag_version is None. I also added the parameterized unit tests you suggested. They explicitly verify that the executor successfully sends the callback requests in both scenarios (when dag_version is present and when it is None). Let me know if the updated approach looks good to you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
