imrichardwu commented on code in PR #61878:
URL: https://github.com/apache/airflow/pull/61878#discussion_r2842796150


##########
airflow-core/src/airflow/utils/helpers.py:
##########
@@ -50,6 +50,55 @@
 S = TypeVar("S")
 
 
+def _truncate_rendered_value(rendered: str, max_length: int) -> str:

Review Comment:
   > Why is the function declared 'private' if it's meant to be imported in 
task_runner and serialization module?
   > 
   > Not sure the linter will like that.
   
   You're right, the function was not in the helper file before and was 
duplicated across 2 files before, therefore it was a private function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to