Miretpl commented on code in PR #61018:
URL: https://github.com/apache/airflow/pull/61018#discussion_r2843455662
##########
chart/templates/_helpers.yaml:
##########
Review Comment:
```suggestion
- sh
- -c
- |
CONNECTION_CHECK_MAX_COUNT=0 AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR exec
/entrypoint \
airflow jobs check --local --job-type DagProcessorJob
```
##########
chart/docs/manage-dag-files.rst:
##########
@@ -121,26 +121,6 @@ for details.
# Please refer to values.yaml for details
-Mounting Dags using git-sync sidecar without persistence
-........................................................
-
-This option will use an always running Git-Sync sidecar on every scheduler,
webserver (if ``airflowVersion < 2.0.0``)
-and worker pods.
-The Git-Sync sidecar containers will sync Dags from a git repository every
configured number of
-seconds. If you are using the ``KubernetesExecutor``, Git-sync will run as an
init container on your worker pods.
-
-.. code-block:: bash
-
- helm upgrade --install airflow apache-airflow/airflow \
- --set dags.persistence.enabled=false \
- --set dags.gitSync.enabled=true
- # you can also override the other gitSync values
- # by setting the dags.gitSync.* values
- # Refer values.yaml for details
-
-When using ``apache-airflow >= 2.0.0``, :ref:`Dag Serialization
<apache-airflow:dag-serialization>` is enabled by default,
-hence Webserver does not need access to Dag files, so ``git-sync`` sidecar is
not run on Webserver.
-
Review Comment:
This section is still valid, but just without scheduler/webserver components
(valid for workers and pod-template), isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
