o-nikolas commented on PR #62307:
URL: https://github.com/apache/airflow/pull/62307#issuecomment-3947877143
> @jscheffl @o-nikolas — Sorry for the confusion with #61935 running in
parallel. Here's what happened and what's changed:
>
> **What went wrong:** I agreed to implement Option 1 (move fix to AWS
provider) but the previous commits on this PR still had the code in
`KubernetesHook`. That's why you saw no changes on #61935 and the same
AWS-specific code here.
>
> **What's fixed now:** The latest commit implements Option 1 as discussed:
>
> 1. **Reverted** all AWS exec-auth guardrail code from `KubernetesHook`
— the K8s provider is now completely cloud-agnostic again
>
> 2. **Added** `EksHook._ensure_aws_cli_cache_dir()` in the AWS provider
that pre-creates `~/.aws/cli/cache` with `exist_ok=True` before
`generate_config_file()` runs
>
> 3. This is the same one-line fix applied upstream in botocore 1.40.2,
just done earlier in the call chain
>
>
> PRs #61935 and #61936 can be closed — this PR now supersedes both.
>
> Would appreciate your re-review. Thanks for the patience! 🙏
This looks like an AI produced message that adds more confusion than answers.
1) Was anything actually reverted here? This is a new PR? Why not just
start fresh?
3) As @jscheffl pointed out, if we already have a min dependency on 1.41.0
why do we still need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
