qaziashikin commented on code in PR #62240: URL: https://github.com/apache/airflow/pull/62240#discussion_r2843700559
########## providers/amazon/src/airflow/providers/amazon/aws/hooks/sagemaker_unified_studio_notebook.py: ########## @@ -0,0 +1,218 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""This module contains the Amazon SageMaker Unified Studio Notebook Run hook.""" + +from __future__ import annotations + +import time +import uuid + +import boto3 + +from airflow.providers.common.compat.sdk import AirflowException, BaseHook + +TWELVE_HOURS_IN_MINUTES = 12 * 60 + + +class SageMakerUnifiedStudioNotebookHook(BaseHook): Review Comment: It seems like this question and decision was made in the PR for the previous operator: https://github.com/apache/airflow/pull/45726#discussion_r1933000524. I think the same idea applies here, we don't need AWS connection management. Do you think there is a still a good reason for using the Aws classes? ########## providers/amazon/src/airflow/providers/amazon/aws/hooks/sagemaker_unified_studio_notebook.py: ########## @@ -0,0 +1,218 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""This module contains the Amazon SageMaker Unified Studio Notebook Run hook.""" + +from __future__ import annotations + +import time +import uuid + +import boto3 + +from airflow.providers.common.compat.sdk import AirflowException, BaseHook + +TWELVE_HOURS_IN_MINUTES = 12 * 60 + + +class SageMakerUnifiedStudioNotebookHook(BaseHook): Review Comment: It seems like this question and decision were made in the PR for the previous operator: https://github.com/apache/airflow/pull/45726#discussion_r1933000524. I think the same idea applies here, we don't need AWS connection management. Do you think there is a still a good reason for using the Aws classes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
