dwreeves commented on PR #62378:
URL: https://github.com/apache/airflow/pull/62378#issuecomment-3953895699

   OK, assuming CI passes, I think we're at a good spot.
   
   - Added support for plain text secret key, which makes the upgrade path from 
<6.3.0 much easier, while still supporting ≥6.3.0 behavior of b64encoded 
private keys.
   - Updated docs.
   - Excluding tests, net negative lines of code via removing repetitive code 
which handles the private key. Neat!
   
   ---
   
   **The only unknown**, and it would be helpful for a maintainer to chime in 
😄, is the question of whether there are reasons _other than the UI_ that 
private keys in plain text are no longer supported. Based on looking through 
discussions, I did not see any reasons other than the UI. I'd be interested in 
hearing if there are other reasons. If not, I would argue that this is an 
appropriate feature addition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to