ferruzzi commented on code in PR #62374:
URL: https://github.com/apache/airflow/pull/62374#discussion_r2848952640
##########
airflow-core/src/airflow/ui/openapi-gen/requests/services.gen.ts:
##########
@@ -3923,17 +3923,25 @@ export class DeadlinesService {
* Get all deadlines for a specific DAG run.
* @param data The data for the request.
* @param data.dagId
- * @param data.runId
- * @returns DeadlineResponse Successful Response
+ * @param data.dagRunId
+ * @param data.limit
+ * @param data.offset
+ * @param data.orderBy Attributes to order by, multi criteria sort is
supported. Prefix with `-` for descending order. Supported attributes: `id,
deadline_time, created_at, alert_name`
+ * @returns DealineCollectionResponse Successful Response
* @throws ApiError
*/
public static getDagRunDeadlines(data: GetDagRunDeadlinesData):
CancelablePromise<GetDagRunDeadlinesResponse> {
return __request(OpenAPI, {
method: 'GET',
- url: '/ui/deadlines/{dag_id}/{run_id}',
+ url: '/ui/dags/{dag_id}/dagRuns/{dag_run_id}/deadlines',
Review Comment:
OK, I can see that. Future plans include deadlines at other levels, such as
per task. So when those are added, the uri would be
`/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/{task_id}/deadlines` ?
And I guess when we add asset/dataset/event based deadline references, the
deadline itself will still be attached to a dagrun, so all of those would reuse
your path. I think I get it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
