jedcunningham commented on code in PR #62129:
URL: https://github.com/apache/airflow/pull/62129#discussion_r2849338534
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -588,7 +619,9 @@ def run_next(self, next_job: KubernetesJob) -> None:
pod_override_object=kube_executor_config,
base_worker_pod=base_worker_pod,
with_mutation_hook=True,
+ workload_secret_name=secret_name or None,
Review Comment:
```suggestion
workload_secret_name=secret_name,
```
nit (2/2)
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py:
##########
@@ -553,12 +558,38 @@ def run_next(self, next_job: KubernetesJob) -> None:
pod_template_file = next_job.pod_template_file
dag_id, task_id, run_id, try_number, map_index = key
+
+ pod_id = create_unique_id(dag_id, task_id)
+ secret_name = ""
Review Comment:
```suggestion
secret_name: str | None = None
```
nit (1/2)- a bit cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
