henry3260 commented on PR #62239: URL: https://github.com/apache/airflow/pull/62239#issuecomment-3954806145
> > > What kind of practical gains are we talking about here? Are there any implications of moving to using anyio? > > > > > > Practical gains: this removes the busy‑wait loop so we don’t trade CPU for latency. Waiting on an Event wakes immediately on signal with minimal wakeups, which cuts idle CPU usage and improves responsiveness. It also makes the intent clearer (wait-until-or-timeout) instead of a manual sleep loop. > > implications: `anyio.move_on_after()` cancels the scope on timeout rather than waking periodically, so we shouldn’t rely on periodic ticks. Also we should use `anyio.Event` consistently (not mix with `asyncio.Event`). > > By what are the practical gains, I more meant what are we actually saving here. Scientifically it may be faster, but are we talking microseconds here? I generally prefer to avoid churn and changes like this if we can. But also the changes are pretty minimal in this case. I'd say it depends on the user's `poke_interval`. If it's set to a larger value (e.g., 60s or 120s), this change significantly reduces redundant checks and resource idling -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
