Nataneljpwd commented on PR #61637: URL: https://github.com/apache/airflow/pull/61637#issuecomment-3955000044
> I am unsure about if it is really a good idea to add a second parameter with additional complexity in logic if there is already one which is (known not be be perfect but already covers 90%). I think adding another second method adds also mental load for users to understand as well as is a risk of inconsistency. I agree about the mental load, the method is quite complex (due to the mix of on_finish actions), maybe it can be done in a different place to reduce the mental load by offloading from the given method, I agree that there are not too many use cases for it, but they do exist, maybe even making an on finish action of delete by phase could make the code much lighter for the reader, what do you think? > As there are many users using K8s I am a bit afraid that such change on a "public API" is more costly than the benefits gained. Therefore I was stepping a bit back waiting for other feedback. Still am not really convinced and would ask if other maintainers see a larger benefit - then I'd not block the merge. In a classic vote in devlist I'd give a "0" (not -1 and no +1) I can see the point here, where the change might outweigh the benefit, if the feature is indeed needed, it is possible to either simplify the change or increase the benefit of the feature (which I don't know how this can be done) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
