nickstenning commented on code in PR #62436:
URL: https://github.com/apache/airflow/pull/62436#discussion_r2852789767
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -1222,17 +1221,9 @@ def emit_metrics(*, parse_time: float, stats:
Sequence[DagFileStat]):
This is called once every time around the parsing "loop" - i.e. after
all files have been parsed.
"""
- with DebugTrace.start_span(span_name="emit_metrics",
component="DagFileProcessorManager") as span:
- Stats.gauge("dag_processing.total_parse_time", parse_time)
- Stats.gauge("dagbag_size", sum(stat.num_dags for stat in stats))
- Stats.gauge("dag_processing.import_errors", sum(stat.import_errors for
stat in stats))
- span.set_attributes(
- {
- "total_parse_time": parse_time,
- "dag_bag_size": sum(stat.num_dags for stat in stats),
- "import_errors": sum(stat.import_errors for stat in stats),
- }
- )
+ Stats.gauge("dag_processing.total_parse_time", parse_time)
Review Comment:
I think at _some_ point having some tracing in the dag processor would be
nice. I think it's fine to rip this out for now, especially as it's in
completely the wrong place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
