[
https://issues.apache.org/jira/browse/AIRFLOW-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994849#comment-16994849
]
ASF GitHub Bot commented on AIRFLOW-6239:
-----------------------------------------
robinedwards commented on pull request #6804: [AIRFLOW-6239] Filter dags return
by last_dagruns
URL: https://github.com/apache/airflow/pull/6804
Add dag_ids get parameter to last_dagruns endpoint so can filter by the
set of dag_ids present on the dags view. This is intended to speed up
the response time on systems running a large number of dags.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-6239
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
The last_dagruns endpoint returns all dags by default. This can result in an
extremely slow response time when you have a lot of dags (In our case 1500+
takes 8 seconds).
The accompanying pull request adds a dag_ids get parameter to the
last_dagruns end point which is populated by the dags present on the page.
Please see related and merged issue for task_stats:
https://issues.apache.org/jira/browse/AIRFLOW-6095
### Tests
- [x] My PR adds the following unit tests
(see test_views)
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Last_dagruns endpoint incredibly slow
> -------------------------------------
>
> Key: AIRFLOW-6239
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6239
> Project: Apache Airflow
> Issue Type: Improvement
> Components: api, ui
> Affects Versions: 2.0.0, 1.10.6
> Reporter: Robin Edwards
> Priority: Minor
>
> The last_dagruns endpoint returns all dags by default. This can be incredibly
> slow when running are large amount of dags (1500+ in our case)
> The accompanying pull request adds a dag_ids get parameter to the dag_stats
> end point which is populated by the dags present on the page.
> Please see previous issue for task_stats AIRFLOW-6095 which has already been
> merged with a similar solution
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
