jedcunningham commented on code in PR #61936:
URL: https://github.com/apache/airflow/pull/61936#discussion_r2855678618
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -56,6 +60,11 @@
from kubernetes.client.models import CoreV1Event, CoreV1EventList, V1Job,
V1Pod
LOADING_KUBE_CONFIG_FILE_RESOURCE = "Loading Kubernetes configuration file
kube_config from {}..."
+_AWS_EXEC_AUTH_VERSION_CHECK_MODE_FIELD =
"exec_auth_aws_cli_version_check_mode"
+_AWS_EXEC_AUTH_VERSION_CHECK_MODES = {"warn", "fail", "ignore"}
+_AWS_EXEC_AUTH_AWS_BINARY_NAMES = {"aws", "aws.exe", "aws2", "aws2.exe"}
+_AWS_EXEC_AUTH_FIXED_BOTOCORE_VERSION = (1, 40, 2)
+_BOTOCORE_VERSION_PATTERN =
re.compile(r"botocore/(?P<version>\d+(?:\.\d+){1,2})")
Review Comment:
I'm pretty hesitant to add this much code to add a min version check like
this, especially one that isn't really directly related to this provider.
The [lower bound in the amazon
provider](https://github.com/apache/airflow/blob/6d6f8bf3d04fc3ee90a3dfd6f5c1e980dabb549a/providers/amazon/pyproject.toml#L69)
is already higher than what we'd defend against here. And, our constraint
files are already putting in a higher version. (2.11.1 has the new version,
2.11.0 did not, fwiw)
If we went with the proposed generic validator + validate botocore version
in the aws provider, we'd not have a problem because of the min version over
there (ignoring _when_ that min was bumped over there).
I'm just wondering if this is now not really a likely issue with the latest
versions of stuff already...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
