TobKed commented on a change in pull request #6776: [AIRFLOW-6220] BigQuery -
remove redundant hook tests after renaming
URL: https://github.com/apache/airflow/pull/6776#discussion_r357248589
##########
File path: tests/gcp/hooks/test_bigquery_system.py
##########
@@ -31,51 +30,26 @@ class
BigQueryDataframeResultsSystemTest(unittest.TestCase):
def setUp(self):
self.instance = hook.BigQueryHook()
- @mock.patch(
- 'airflow.gcp.hooks.base.GoogleCloudBaseHook.project_id',
- new_callable=mock.PropertyMock,
- return_value=None
- )
- def test_output_is_dataframe_with_valid_query(self, mock_project_id):
+ def test_output_is_dataframe_with_valid_query(self):
Review comment:
Actually it is not. I will rollback these changes and create separate PR for
this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
