sjyangkevin opened a new pull request, #62604:
URL: https://github.com/apache/airflow/pull/62604
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
* closes: #50752
### Why
The error occurs because pendulum objects are serialized with pendulum v3
(in the Airflow environment) but deserialized with pendulum v2 (in the
virtualenv), and the two versions have incompatible internal class structures.
The pendulum objects are coming from the `PENDULUM_SERIALIZABLE_CONTEXT_KEYS`
### Fix
1. check if pendulum is defined in the `requirements` and check the if any
version specified
2. evaluate the version string and check if the major version mismatch
3. if the major version mismatch, before serializing in `_write_args`,
convert pendulum `DateTime` objects to `datetime.datetime` with
`zoneinfo.ZoneInfo` timezone info, which can be serialized and deserialized
without pendulum.
4. A flag is passed into Jinja template to render the code to convert the
`datetime.datetime` back to `pendulum.Datetime`
5. Before returning to the Airflow environment, convert back to
`datetime.datetime` before being serialized in the virtual environment.
### Tests
1. specify `requirements` with `["pendulum<3"]`, and test against `pickle`,
`cloudpickle`, and `dill`
2. specify `requirements` with `["pendulum>=3"]`, and test against `pickle`,
`cloudpickle`, and `dill`
3. specify `requirements` with `["pendulum"]`, and test against `pickle`,
`cloudpickle`, and `dill`
4. do not specify `requirements` (i.e., `requirements=None`), and test
against `pickle`, `cloudpickle`, and `dill`
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Generated-by: [Antigravity] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
I use it to suggest the way to compare version mismatch. I originally think
to check just the major version difference. However, the tool suggest the
following:
>we cannot simply compare major versions because a requirement is usually a
range, not a single version number. For example, what is the "major version" of
a requirement like `pendulum>=2,<4`? It allows any version in the 2.x and 3.x
line. Or what about pendulum!=3.0.0? Because `req.specifier` is a
`SpecifierSet` containing complex mathematical boundaries (not a single
version), the only truly robust way to ask "Does this requirement allow the
host's major version?" is to ask the `SpecifierSet` to validate some versions
within that major release line.
I am open to learn more if there is a better way to check it.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
