Leondon9 commented on PR #62626:
URL: https://github.com/apache/airflow/pull/62626#issuecomment-3978977705

   Thanks @SameerMesiah97 for the review!
   
   **Comment 1 (NotFullyPopulated/NotMapped split):** Good point — `NotMapped` 
is indeed a user input error, not an ambiguous runtime state. I've split them 
so `NotMapped` raises a clear `ValueError`.
   
   **Comment 2 (test pattern):** Makes sense, `pytest.raises` is the standard 
pattern. I've updated the test to use `pytest.raises(Exception)` with a 
negative assertion on the error message.
   
   Both changes pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to