jscheffl commented on code in PR #61798:
URL: https://github.com/apache/airflow/pull/61798#discussion_r2869559166
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -79,14 +79,29 @@ class KubernetesExecutor(BaseExecutor):
RUNNING_POD_LOG_LINES = 100
supports_ad_hoc_ti_run: bool = True
+ supports_multi_team: bool = True
if TYPE_CHECKING and AIRFLOW_V_3_0_PLUS:
# In the v3 path, we store workloads, not commands as strings.
# TODO: TaskSDK: move this type change into BaseExecutor
queued_tasks: dict[TaskInstanceKey, workloads.All] # type:
ignore[assignment]
- def __init__(self):
- self.kube_config = KubeConfig()
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
Review Comment:
I was referring to the _order_ of setting parallelism. Before the super()
constructor was called in line 103. Now it is called first and then in line
(new) 103 the parallelism is set.
I think it is okay, but just wanted to double-check.
My comment was _not_ about the **kwargs method of calling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
